consoles: Redesign #2008
Draft
consoles: Redesign #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -20,140 +20,187 @@ | |||
| import PropTypes from 'prop-types'; | |||
| import cockpit from 'cockpit'; | |||
| import { AccessConsoles } from "@patternfly/react-console"; | |||
| import { Button } from "@patternfly/react-core/dist/esm/components/Button"; | |||
| import { Card, CardBody, CardFooter, CardHeader, CardTitle } from '@patternfly/react-core/dist/esm/components/Card'; | |||
| import { ExpandIcon, HelpIcon } from '@patternfly/react-icons'; | |||
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
| import { Divider } from "@patternfly/react-core/dist/esm/components/Divider"; | ||
| import { EmptyState, EmptyStateBody, EmptyStateFooter } from "@patternfly/react-core/dist/esm/components/EmptyState"; | ||
| import { Split, SplitItem } from "@patternfly/react-core/dist/esm/layouts/Split/index.js"; | ||
| import { DescriptionList, DescriptionListTerm, DescriptionListGroup, DescriptionListDescription } from "@patternfly/react-core/dist/esm/components/DescriptionList"; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
Comment on lines
+22
to
+26
| import { | ||
| FormGroup, FormHelperText, HelperText, HelperTextItem, | ||
| Grid, GridItem, | ||
| InputGroup, TextInput, Button, Checkbox | ||
| } from "@patternfly/react-core"; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
| Grid, GridItem, | ||
| InputGroup, TextInput, Button, Checkbox | ||
| } from "@patternfly/react-core"; | ||
| import { Split, SplitItem } from "@patternfly/react-core/dist/esm/layouts/Split/index.js"; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
- The dialogs talk about "server" and "listening" to make that clearer. - We use the empty string instead of "-1" to signify automatic port assignment in the UI. - The port does validation of its value. - The password field takes the whole row and has can reveal its value. - The dialogs warn if a shutdown is needed. - The components take the whole "vm" object instead of separate name, id, and connectionName.
We are not comfortable with that without also offering encryption.
- The "Console" card is always present and let's people manage VNC server settings while the machine is off. - The "Graphical console" tab is always present when the machine is running and let's people add VNC. - There is no way yet to change VNC server settings for a running machine since there is no good place for the button that would open the dialog.
Things will get more much more complicated.
…ewer We want to invoke that dialog also from the "Console" card, where it is used to enable the inline graphical console viewer.
- A ToggleGroup in the Card header is used to switch consoles - The DesktopViewer is gone, but there is a footer with a "Launch viewer" button and a "How to connect" popup. - Can't change consoles in the expanded view, but the expanded console keeps the type that was active in the collapsed view. TODO: - Code cleanup, "VncConsole" is now really "GraphicsConsole", etc..
mvollmer
force-pushed
the
console-redesign
branch
from
44f3e69 to
69dcfd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo: https://www.youtube.com/watch?v=pKqvfQ3lDQQ