Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ordering paramter to openApiPaginator #564

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MasaKni
Copy link
Contributor

@MasaKni MasaKni commented Feb 5, 2025

adding the possibility to order by array of fields, current behaviour adds sorting in one param
'#/x-swagger-bake/components/parameters/paginatorSort ,

this creates an array of objects with
{ "field": "name", "dir": "asc" }
Screenshot 2025-02-07 at 10 53 29

@cnizzardini
Copy link
Owner

@MasaKni can you provide a description for this and also please respond to the many comments I've made in your other PR #563 before I close it out. It's enough of a pain in the ass being a maintainer, so respond to comments when I make them. I have a shit ton of fucking packages I maintain and this is fucking time consuming.

@MasaKni
Copy link
Contributor Author

MasaKni commented Feb 7, 2025

@MasaKni can you provide a description for this and also please respond to the many comments I've made in your other PR #563 before I close it out. It's enough of a pain in the ass being a maintainer, so respond to comments when I make them. I have a shit ton of fucking packages I maintain and this is fucking time consuming.

I did resolve them... It just took me time because i am also working on other projects.
I have moved the functionality for ordering here, so we would choose a structure to how we wanna build the array of ordering.

@cnizzardini
Copy link
Owner

@MasaKni take a look at that merge conflict. Once that is resolved I'll pull this branch down for testing.

@MasaKni
Copy link
Contributor Author

MasaKni commented Feb 10, 2025

@MasaKni take a look at that merge conflict. Once that is resolved I'll pull this branch down for testing.

resolved

@cnizzardini
Copy link
Owner

cnizzardini commented Feb 11, 2025

@MasaKni I see this in Swagger when I pull in this branch. This doesn't appear to work. Are there additional instructions to follow? Maybe focus on getting this working in https://editor.swagger.io/ where it also looks like the screenshot below. Won't merge this as-is.

image

@MasaKni
Copy link
Contributor Author

MasaKni commented Feb 13, 2025

it does look like this when you don't hit the try it out button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants