-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hebrew translation of Code of Conduct #862
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Emmanuel Ferdman <[email protected]>
Signed-off-by: Emmanuel Ferdman <[email protected]>
Signed-off-by: Emmanuel Ferdman <[email protected]>
@mrbobbytables @brooksmtownsend @Cmierly Could you please review this PR? |
Hey @emmanuel-ferdman I'm not a TOC member, but thanks for your hard work on the translation 😄 |
This translation looks good to me. @nate-double-u @mrbobbytables is there a separate TOC approval step? |
No separate TOC approval step needed, but translations should be approved by at least 2 target language readers/writers from the community. @emmanuel-ferdman are you able to recruit two such reviewers? The CNCF Glossary has an active localization community, as does Kubernetes, they may be able to help here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, נראה טוב
נראה מעולה, עבודה יפה.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😄
@nate-double-u I was able to recruit two Hebrew speaking users which approved this PR. Anything else is needed from my side? |
PR Summary
The PR adds Hebrew translation of Code of Conduct.