-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update trademark_disclaimer to allow for new URL #797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @matthewpereira! One minor detail and this is ready to go 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me @matthewpereira, thanks!
@matthewpereira can you format the |
And also rebase from main if you don't mind, we've just merged another PR. Thanks! |
In order to account for The Linux Foundation's new `/legal/trademark-usage` route, this regex on line 20 adds an optional `legal/` capture group. Signed-off-by: Matthew Pereira <[email protected]> Signed-off-by: Administrator <[email protected]>
Signed-off-by: Matthew Pereira <[email protected]> Signed-off-by: Administrator <[email protected]>
Signed-off-by: Matthew Pereira <[email protected]> Signed-off-by: Administrator <[email protected]>
Signed-off-by: Cintia Sanchez Garcia <[email protected]> Signed-off-by: Administrator <[email protected]>
Signed-off-by: Cintia Sanchez Garcia <[email protected]> Signed-off-by: Administrator <[email protected]>
Related to #761 Signed-off-by: Sergio Castaño Arteaga <[email protected]> Signed-off-by: Cintia Sanchez Garcia <[email protected]> Co-authored-by: Sergio Castaño Arteaga <[email protected]> Co-authored-by: Cintia Sanchez Garcia <[email protected]> Signed-off-by: Administrator <[email protected]>
Signed-off-by: Sergio Castaño Arteaga <[email protected]> Signed-off-by: Administrator <[email protected]>
Signed-off-by: Sergio Castaño Arteaga <[email protected]> Signed-off-by: Administrator <[email protected]>
Signed-off-by: Bill Mulligan <[email protected]> Signed-off-by: Administrator <[email protected]>
Signed-off-by: Sergio Castaño Arteaga <[email protected]> Signed-off-by: Administrator <[email protected]>
Signed-off-by: Matthew Pereira <[email protected]>
I think I've made a mess of this, due to working on my personal machine over the holidays instead of continuing on my work machine. 🙃 I'm going to start fresh with a clean PR if that's alright with y'all. |
Sure, no problem 👍 |
In order to account for The Linux Foundation's new
/legal/trademark-usage
route, this regex on line 20 adds an optionallegal/
capture group.Review and feedback appreciated. 🙇
Addresses comments in #33 .