forked from lux-org/lux
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit test implement #25
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…argument when calling append_event
… to the unit tests implemented before, including the parent-child relationship and the length of the history examination
…lay calls in previous unit tests
…e removal of most metadata attributes)
…example, in the mean, median case
…min, sum, median etc.
…ly added around the condition and the warning so that assertions are always true
…lude the scatter plot with ndim = 1 and nmsr = 3 despite one of the measure attribute is never used
…the Similarity tab
…failure for the current version
…nt codes have been deleted
…g the history when comparing and adding default value for df._prev
…ccur to me that slice object not only supports consecutive characters like a:e but also for consecutive columns in a dataframe
…rked for CustomVis though)
…ll be added to the original column name in the figure
…red class object and whenever it is used to create a histogram or a line/bar chart, the channel is sometimes changed to y or x. When it is used another time, the Record channel has been already specified
…hich was caused by the default config of the heatmap was turned to false
…hich was caused by the default config of the heatmap was turned to false
…istory logging in other unit tests affect the unit tests in these files
…es and order plots
…orders and also stop using the shared dataset car_df
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeted at issue #3.
Mainly implement the unit test for history logging and the history class (for
append_event
,check_event
, andget_mre
etc.), and also check for all unit tests in the original lux library, reporting bugs in our library as issues if the failure is complicated and fixed easier ones, as well as changing some small parts of the unit tests for those that are not applicable any more. )