Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test implement #25

Merged
merged 76 commits into from
Aug 3, 2021
Merged

Unit test implement #25

merged 76 commits into from
Aug 3, 2021

Conversation

leijie-wang
Copy link

Targeted at issue #3.

Mainly implement the unit test for history logging and the history class (for append_event, check_event, and get_mre etc.), and also check for all unit tests in the original lux library, reporting bugs in our library as issues if the failure is complicated and fixed easier ones, as well as changing some small parts of the unit tests for those that are not applicable any more. )

Acorn added 30 commits July 1, 2021 16:03
… to the unit tests implemented before, including the parent-child relationship and the length of the history examination
Acorn and others added 28 commits July 8, 2021 09:33
…ly added around the condition and the warning so that assertions are always true
…lude the scatter plot with ndim = 1 and nmsr = 3 despite one of the measure attribute is never used
…g the history when comparing and adding default value for df._prev
…ccur to me that slice object not only supports consecutive characters like a:e but also for consecutive columns in a dataframe
…ll be added to the original column name in the figure
…red class object and whenever it is used to create a histogram or a line/bar chart, the channel is sometimes changed to y or x. When it is used another time, the Record channel has been already specified
…hich was caused by the default config of the heatmap was turned to false
…hich was caused by the default config of the heatmap was turned to false
…istory logging in other unit tests affect the unit tests in these files
…orders and also stop using the shared dataset car_df
@willeppy willeppy merged commit 8bb27c4 into master Aug 3, 2021
@willeppy willeppy deleted the unit-test-implement branch August 3, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants