You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Edit the existing tests for lux to make sure they are accurate (many will not run now because I have made changes but did not change the tests)
Add new tests for the new functionality we have added.
Files / functionality that need NEW unit tests:
History logging in frame.py
Make sure all override functions log the correct history and nothing extra
History tracking in series.py (same as above)
History tracking in groupy.py (same as above)
History class in history.py
Lots of new functions here to make sure history is stored well
Clause mark type specification
In Clause.py I added a mark_type parameter to make sure that column ends up as a vis with a certain mark type but haven't written tests to make sure this is actually enforced. Mostly means adding tests to compiler to make sure the clause results in visualizations that are of this mark type
Rewritten compiler
I rewrote the compiler to be more streamlined and include functionality as mentioned above so lots of the tests are failing for the compiler
new plotters in implicit_plotter.py and cg_plotter.py.
These might be a little tough to write tests for since they can have a huge number of inputs but it would be good to have some unit tests that make sure that they aren't broken. For example making sure that when df.describe() is called it produces a box plot and the right history.
Other files had small changes that are breaking existing tests. These tests should be amended to make sure that they are testing for good functionality and also comply with the changes.
The text was updated successfully, but these errors were encountered:
This is almost complete, just need to fix a couple remaining things
================================================================================= short test summary info =================================================================================
FAILED tests/test_action.py::test_crosstab - pandas.core.indexing.IndexingError: Unalignable boolean Series provided as indexer (index of the boolean Series and of the indexed object d...
FAILED tests/test_performance.py::test_lazy_maintain_performance_census - AssertionError: Subsequent display of recommendations on Census dataset took a total of {delta2:0.4f} seconds,...
================================================================= 2 failed, 261 passed, 449 warnings in 542.63s (0:09:02) =================================================================
Need to add tests for new functionality.
This requires two things
Files / functionality that need NEW unit tests:
frame.py
series.py
(same as above)groupy.py
(same as above)history.py
Clause.py
I added a mark_type parameter to make sure that column ends up as a vis with a certain mark type but haven't written tests to make sure this is actually enforced. Mostly means adding tests to compiler to make sure the clause results in visualizations that are of this mark typeimplicit_plotter.py
andcg_plotter.py
.df.describe()
is called it produces a box plot and the right history.Other files had small changes that are breaking existing tests. These tests should be amended to make sure that they are testing for good functionality and also comply with the changes.
The text was updated successfully, but these errors were encountered: