Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code needs clean up and reorganisation #22

Open
2 of 5 tasks
fwyzard opened this issue Dec 28, 2015 · 0 comments
Open
2 of 5 tasks

code needs clean up and reorganisation #22

fwyzard opened this issue Dec 28, 2015 · 0 comments

Comments

@fwyzard
Copy link
Contributor

fwyzard commented Dec 28, 2015

  • remove default parameter values, unless it really makes sense for such parameters to be optional
  • most functions should not accept both a configuration "branch" (e.g. /dev/CMSSW_7_6_0/HLT) and a specific version (e.g. /dev/CMSSW_7_6_0/HLT/V14). A single function should convert a branch to its latest version.
  • move all ConfDB v2 code in a single package (e.g. confdb_v2/)
  • remove the code duplication between exposed and converter
  • remove commented out sections of code
fwyzard added a commit to fwyzard/web-confdb that referenced this issue Dec 28, 2015
@fwyzard
code cleanup (see cms-sw#22)
beedaea 
  - clean up comments
fwyzard added a commit to fwyzard/web-confdb that referenced this issue Dec 28, 2015
@fwyzard
code cleanup (see cms-sw#22)
15654ff 
  - remove default parameter values
fwyzard added a commit to fwyzard/web-confdb that referenced this issue Dec 28, 2015
@fwyzard
code cleanup (see cms-sw#22)
3a32ab7 
  - move all ConfDB v2 code in a single package
fwyzard added a commit to fwyzard/web-confdb that referenced this issue Dec 28, 2015
@fwyzard
code cleanup (see cms-sw#22)
f876de2 
  - remove default parameter values
fwyzard added a commit to fwyzard/web-confdb that referenced this issue Jan 13, 2016
@fwyzard
code cleanup (see cms-sw#22)
f02ee39 
  - move all ConfDB v2 code in a single package
fwyzard added a commit to fwyzard/web-confdb that referenced this issue Jan 13, 2016
@fwyzard
code cleanup (see cms-sw#22)
d32bc07 
  - remove default parameter values
fwyzard added a commit to fwyzard/web-confdb that referenced this issue Jan 13, 2016
@fwyzard
code cleanup (see cms-sw#22)
9bb4019 
  - move all ConfDB v2 code in a single package
fwyzard added a commit to fwyzard/web-confdb that referenced this issue Jan 13, 2016
@fwyzard
code cleanup (see cms-sw#22)
6d7cd4b 
  - remove default parameter values
fwyzard added a commit to fwyzard/web-confdb that referenced this issue Jan 14, 2016
@fwyzard
code cleanup (see cms-sw#22)
1f9d5f3 
  - remove default parameter values
fwyzard added a commit to fwyzard/web-confdb that referenced this issue Jan 14, 2016
@fwyzard
code cleanup (see cms-sw#22)
b066249 
  - clean up comments
  - remove default parameter values
  - move all ConfDB v2 code in a single package
vinnie87 added a commit that referenced this issue Jan 14, 2016
@vinnie87
Merge pull request #23 from fwyzard/cleanup
78ce420 
code cleanup (see #22)
All files checked, and bugs fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fwyzard