Skip dinamically some checks for the validation procedure #1182
Conversation
|
looks good. |
|
what's the prospect of rolling this in production "soon" ? |
ggonzr
force-pushed
the
validation/skip-checks
branch
2 times, most recently
from
b3c5dc2 to
eb0be24
Compare
ggonzr
force-pushed
the
validation/skip-checks
branch
2 times, most recently
from
9862cd8 to
0dc7150
Compare
|
there's actually something else to be added for this feature : cmsPdmV/mcm/json_layer/request.py Line 3028 in 438ec71 filter_efficiency should not be re-assigned, in case the prepid is in the bypass check |
ggonzr
force-pushed
the
validation/skip-checks
branch
from
0dc7150 to
eb13eb4
Compare
Thanks for the feedback, it should be fixed now |
|
nice |
ggonzr
force-pushed
the
validation/skip-checks
branch
from
eb13eb4 to
3935baf
Compare
For a given request prepid set in the `validation_skip_check`, skip if required some checks related to the `time_per_event`, `size_per_event` `memory` and `filter_efficiency`.
ggonzr
force-pushed
the
validation/skip-checks
branch
from
3935baf to
b6cff91
Compare
|
https://cms-pdmv-prod.web.cern.ch/mcm/public/restapi/requests/get_dict/SUS-RunIISpring21UL16FSGSPremixLLPBugFix-00071 does not seem to pick up the request values instead of the runtests results |
|
|
||
| # Filter efficiency was not check on validation | ||
| filter_efficiency = self.get_efficiency() | ||
| request_skip_check = self.get_allowed_skip_validation_check().get(self.get_attribute("prepid")) |
There was a problem hiding this comment.
from the code in the PR and the failing check on https://cms-pdmv-prod.web.cern.ch/mcm/public/restapi/requests/get_dict/SUS-RunIISpring21UL16FSGSPremixLLPBugFix-00071 I can only think of this line failing silently
Solves: #1181
For a given request prepid set in the
validation_skip_checksetting, skip if required some checks related to thetime_per_event,size_per_eventmemoryandfilter_efficiency.