Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in MEU index calculation #257

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

bryates
Copy link

@bryates bryates commented Feb 8, 2024

PR description:

This PR fixes a typo in the variables used to calculate the stub index inside the MEU. I've tested with 44 events and see full agreement with the HLS output.

PR validation:

                      Tracklet  SUMMARY
number of stubs     per TFP = 407.0505 +- 6.1832
number of tracks    per TFP =  75.3081 +- 1.1423
current tracking efficiency =   0.9548 +- 0.0069
max     tracking efficiency =   0.9581 +- 0.0066
                  fake rate =   0.1772
             duplicate rate =   0.6025
=============================================================
                        TBout SUMMARY
number of stubs       per TFP = 407.0505 +- 6.1832
number of tracks      per TFP =  75.3081 +- 1.1423
number of lost tracks per TFP =   0.0000 +- 0.0000
     max  tracking efficiency =   0.9581 +- 0.0066
     lost tracking efficiency =   0.0000 +- 0.0000
                    fake rate =   0.1772
               duplicate rate =   0.6025
=============================================================
                        DRin  SUMMARY
number of stubs       per TFP = 398.5076 +- 6.1446
number of tracks      per TFP =  73.6641 +- 1.1337
number of lost tracks per TFP =   0.0051 +- 0.0036
  current tracking efficiency =   0.9515 +- 0.0071
  max     tracking efficiency =   0.9559 +- 0.0068
     lost tracking efficiency =   0.0000 +- 0.0000
                    fake rate =   0.1772
               duplicate rate =   0.5980
=============================================================
                         DR  SUMMARY
number of stubs       per TFP = 123.4571 +- 1.8858
number of tracks      per TFP =  23.8561 +- 0.3787
number of lost tracks per TFP =   0.0000 +- 0.0000
  current tracking efficiency =   0.9130 +- 0.0094
  max     tracking efficiency =   0.9493 +- 0.0073
     lost tracking efficiency =   0.0000 +- 0.0000
                    fake rate =   0.2369
               duplicate rate =   0.0723
=============================================================
                        KFin  SUMMARY
number of stubs       per TFP = 123.4571 +- 1.8858
number of tracks      per TFP =  23.8561 +- 0.3787
number of lost tracks per TFP =   0.0000 +- 0.0000
  current tracking efficiency =   0.9130 +- 0.0094
  max     tracking efficiency =   0.9493 +- 0.0073
     lost tracking efficiency =   0.0000 +- 0.0000
                    fake rate =   0.2369
               duplicate rate =   0.0723
=============================================================
                         KF  SUMMARY
number of stubs       per TFP = 115.0682 +- 1.7936
number of tracks      per TFP =  23.8561 +- 0.3787
number of lost tracks per TFP =   2.4066 +- 0.1286
          tracking efficiency =   0.9427 +- 0.0077
     lost tracking efficiency =   0.0000 +- 0.0000
                    fake rate =   0.2445
               duplicate rate =   0.0706
    state assessment fraction =   0.7151
=============================================================
                        KFout SUMMARY
number of tracks      per TFP =  23.8561 +- 0.3787
number of lost tracks per TFP =   0.0000 +- 0.0000
          tracking efficiency =   0.9449 +- 0.0076
     lost tracking efficiency =   0.0000 +- 0.0000
                    fake rate =   0.2418
               duplicate rate =   0.0712
=============================================================

@bryates
Copy link
Author

bryates commented Feb 8, 2024

The CI is failing because the efficiency is below the thresholds of 97 and 96% for the HYBRID and HYBRID_NEWKF algorithms. This seems to be the case for all recent PRs.

Copy link
Collaborator

@tomalin tomalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@tomalin tomalin merged commit e6650de into L1TK-dev-14_0_0_pre2 Feb 29, 2024
1 check passed
tomalin pushed a commit that referenced this pull request Mar 7, 2024
tomalin pushed a commit that referenced this pull request Mar 7, 2024
dally96 pushed a commit that referenced this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants