Make it work with Ruby 3.1.4 #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7de2d8e.
* commit '373802cdf6aed5d94d956f962a23507641a90191': Updated dependencies bump Ruby version Version bump Added ability to assign data attributes to modal content Support for Ruby 3.3 # Conflicts: # .tool-versions
|
Was this meant to be closed without merging? I notice that this includes the same fix I made for the action controller loading in #10, which definitely wasn't in main. |
|
I closed it because I wasn't sure this was all that was required to get it compatible with ruby 3.1.4, and I updated my app to ruby 3.2.2 before digging any deeper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure this covers everything, but I was able to get the demo app to work with ruby 3.1.4.