-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos in documentation #32
Conversation
Thanks for your contribution 👍 Pull request itself looks good. The test matrix is currently not running through because of an outdated CI workflow, so we need to make a few adjustments before we can merge this. The changes will be similar to the work done in reactphp/socket#299, reactphp/socket#300 and reactphp/socket#310. Is this something you can look into? |
Thanks to @SimonFrings, I was able to rebase my branch after implementing the new feature described in #33. Fortunately, there were no conflicts, and all tests passed successfully. This PR is now ready to be reviewed by @clue and @SimonFrings. 🎉 |
Really thankful for our workshop. I feel confident that I will be able to work on this independently in the future. 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yadaiio Thanks for rebasing, these changes look good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yadaiio Thanks for looking into this, changes LGTM!
This pull request fixes a few typos with the help of https://github.com/szepeviktor/typos-on-you.
Builds on top of #10 and clue/reactphp-redis#146.