-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the possibility to update and revoke existing premints #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorsenych-cw
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the new functionality, it will be possible to revoke or update existing premints. Function
cashInPremint()
is reverted if the cash-in operation with the passedreleaseTime
already exists, so newly introduced functions should be used to modify existing premints.New Functionality and Changes to Existing Functionality
PIX Cashier
cashInPremintRevoke
function was introduced to revoke existing premints:This function resets the amount of premint to zero and completely erases all the stored information about the premint, allowing the reuse of the cash-in operation ID to create new premints. It can only be executed if the premint's release time has not passed.
cashInPremintUpdate
function was introduced to update existing premints:This function changes the amount of preminted tokens. The new amount can be less or greater than the old amount. It can only be executed if the premint's release time has not passed.
CashInPremint
event was modified; now, it emits one more parameter:In the case of a new premint,
oldAmount
will be equal to zero; otherwise, it would hold the previous amount of the premint.Key Highlights
The common behavior of new functions:
premint()
function of the token contract.The revert conditions for the functions
releaseTime
is zero.amount
passed intocashInPremintUpdate
is zero.txId
is zero.PixCashier
contract.txId
is not a premint.Note
All the functionality regarding premints is separated between two smart contracts:
PixCashier
and token contract.To check the second part, see here
Test coverage
The new functionality was fully covered by tests.
