Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SSL/TLS Connections for Oracle #19

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Support SSL/TLS Connections for Oracle #19

merged 1 commit into from
Oct 22, 2024

Conversation

Vipinofficial11
Copy link
Collaborator

No description provided.

anup-cloudsufi
anup-cloudsufi reviewed Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@anup-cloudsufi anup-cloudsufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure, we don't break any unit test due to this new parameter.

@Vipinofficial11
Copy link
Collaborator Author

Make sure, we don't break any unit test due to this new parameter.

One of the unit test case is failing but not specifically because of the new parameter. It is a negative test scenario which tests connection failure,I think it is failing because we are specifying protocol as tcp explicitly now. Looking into it.

@Vipinofficial11
Copy link
Collaborator Author

Vipinofficial11 commented Oct 10, 2024 •
edited
Loading

Make sure, we don't break any unit test due to this new parameter.

One of the unit test case is failing but not specifically because of the new parameter. It is a negative test scenario which tests connection failure,I think it is failing because we are specifying protocol as tcp explicitly now. Looking into it.

Fixed the unit tests with minor changes in Connection String's format, tested the changes on CDAP for Source Plugin. [ae059c4]

Connection String - jdbc:oracle:thin:@tcp:34.......201:1500/OR....1
Screenshot 2024-10-10 at 9 40 07 AM

anup-cloudsufi
anup-cloudsufi reviewed Oct 10, 2024
View reviewed changes
oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleConstants.java Outdated
}

// For TNS Descriptor we can't specify the protocol in connection string.
if (OracleConstants.TNS_CONNECTION_TYPE.equalsIgnoreCase(connectionType)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see if we can convert it into swtich statement as in general either of the statements will be true. So, we can avoid the compiler navigation to multiple conditional statements.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converted to switch [6c60d2d]

@Vipinofficial11 Vipinofficial11 force-pushed the enableSSLConnections branch 4 times, most recently from b9bf75f to ae5d1c9 Compare October 16, 2024 20:13
@Vipinofficial11 Vipinofficial11 merged commit f0347b9 into develop Oct 22, 2024
2 checks passed
@psainics psainics deleted the enableSSLConnections branch January 22, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anup-cloudsufi anup-cloudsufi anup-cloudsufi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vipinofficial11 @anup-cloudsufi