Fix TypedFormArray controls as array of arrays #177
Conversation
There was a problem hiding this comment.
@zakhenry what do you think?
Good enough for now and maybe we change it to what I said along the next breaking change?
|
Yea agreed, this is an improvement regardless so no reason to delay it |
|
@zakhenry I checked on both ngx-sub-form demo and our own app at CloudNC: We don't have any usage of @jaycetde thanks for your first contribution and welcome 🎉 We use semantic versionning which is then used to generate changelog and releases of the library. Could you please amend your commit with the necessary changes to taken into account my previous comment on the review and also edit the commit name to: Thanks |
|
Yes this is not breaking as it is correcting an incorrectly typed form. It is possible it could break someones compilation, but for the better. Their runtime would be unaffected. |
|
@maxime1992 I'll update the commit name. I'm not quite sure what you mean by "Could you please amend your commit with the necessary changes to taken into account my previous comment on the review". Are you asking me to also include the additional "preferred" changes? If so, I assume lines 24 would also need to be updated from |
controls should be an array of controls that have the single item as the value
jaycetde
force-pushed
the
fix/typed-array-controls-typing
branch
from
15b0122 to
a73d691
Compare
|
@jaycetde @maxime1992 I think we should limit the scope of this change to just what we have here. The commit message looks good, so the release notes will go out fine. I think this MR is good to go 👍 |
|
🎉 This PR is included in version 5.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
controls should be an array of controls that have the single item as the value