Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add src type to CloudinaryLoaderCldOptions interface #552

Merged
merged 9 commits into from
Nov 1, 2024
Merged

feat: add src type to CloudinaryLoaderCldOptions interface #552

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cf4cfa6
feat: add src type to CloudinaryLoaderCldOptions interface
vickywane Oct 15, 2024
ef10edb
chore: rebase upstream origin main
vickywane Oct 19, 2024
6698297
chore: rebase upstream origin main
vickywane Oct 19, 2024
c8fa80d
chore: rebase upstream origin main
vickywane Oct 15, 2024
5acd29c
feat: add empty src value cldOptions object
vickywane Oct 15, 2024
c1648d0
chore: rebase upstream origin main
vickywane Oct 19, 2024
e9b8d30
update: remove cldOptions object spread & revert formatting
vickywane Oct 28, 2024
b524d2b
changing how type is cast
colbyfayock Nov 1, 2024
f8f693d
Merge branch 'beta' into fix/cloudinary-loader-ts
colbyfayock Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion next-cloudinary/src/loaders/cloudinary-loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { ImageProps } from 'next/image';
import { getCldImageUrl } from '../helpers/getCldImageUrl';

export interface CloudinaryLoaderCldOptions {
src: string
}

export interface CloudinaryLoaderLoaderOptions {
Expand Down Expand Up @@ -53,6 +54,5 @@ export function cloudinaryLoader({ loaderOptions, imageProps, cldOptions, cldCon
options.width = loaderOptions?.width;
}

// @ts-ignore
return getCldImageUrl(options, cldConfig);
}
Loading