Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up bundling #116

Merged
merged 4 commits into from
Jun 27, 2022
Merged

Set up bundling #116

merged 4 commits into from
Jun 27, 2022

Conversation

calebeby
Copy link
Member

@calebeby calebeby commented Jun 24, 2022

Closes #44

Run rm -rf dist && npm run build and then check that the built files in dist work:

./index.js https://cloudfour.com

@changeset-bot
Copy link

changeset-bot bot commented Jun 24, 2022

⚠️ No Changeset found

Latest commit: ba4f0dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@calebeby calebeby marked this pull request as draft June 24, 2022 15:47
Base automatically changed from lint-update to next June 24, 2022 20:46
@calebeby calebeby marked this pull request as ready for review June 24, 2022 21:32
@calebeby calebeby mentioned this pull request Jun 24, 2022
16 tasks
Copy link
Member

@spaceninja spaceninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and seems to work as described (I had to abort the test because it was taking too long on my super slow connection, but I could see that the command was running, and scanning URLs on cloudfour.com)

@calebeby calebeby merged commit 621de72 into next Jun 27, 2022
@calebeby calebeby deleted the bundle branch June 27, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants