Use sub query for user visibility filter

In case there are many service instances related db queries might become very complex: ``` SELECT * FROM \"services\" WHERE ((\"services\".\"id\" IN (7)) AND (\"id\" IN (<super long list of service ids>))) ``` This can lead to high memory consumption on the api VMs and can also cause memory bloats as everything is loaded into memory. With this change we change the query to use a sub query instead: ``` SELECT * FROM \"services\" WHERE ((\"services\".\"id\" IN (7)) AND (\"id\" IN (SELECT DISTINCT \"service_id\" FROM \"service_plans\"))) ``` Co-authored-by: Philipp Thun <[email protected]>
cloudfoundry · Dec 5, 2023 · ccd2ffb · ccd2ffb
1 parent 7eeac9a
commit ccd2ffb
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/app/models/services/service.rb b/app/models/services/service.rb
@@ -36,9 +36,8 @@ def public_visible
 
       def user_visibility_filter(current_user, operation=nil)
         visible_plans = ServicePlan.user_visible(current_user, operation)
-        ids_from_plans = visible_plans.map(&:service_id).uniq
 
-        { id: ids_from_plans }
+        { id: visible_plans.select(:service_id).distinct }
       end
 
       def user_visibility_for_read(current_user, _admin_override)