Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle tarballs that do not have dir headers #107

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

ystros
Copy link
Contributor

@ystros ystros commented Dec 4, 2024

The test asset tarball added by this commit contains the following entries:
dir/file1
dir/file2
dir/nested-dir/file3

It explicitly lacks entries for dir/ and dir/nested-dir/. This is how the tar executable generates tarballs when specifying individual files, and is how the BOSH Director creates the file bundle tarballs sent to the BOSH agent.

@ystros ystros changed the base branch from master to develop December 4, 2024 22:05
The test asset tarball added by this commit contains the following
entries:
```
dir/file1
dir/file2
dir/nested-dir/file3
```

It explicitly lacks entries for `dir/` and `dir/nested-dir/`. This is
how the `tar` executable generates tarballs when specifying individual
files, and is how the BOSH Director creates the file bundle tarballs
sent to the BOSH agent.
@ystros ystros force-pushed the handle-missing-dir-headers branch from a94bd55 to 8f7880f Compare December 4, 2024 22:12
Copy link
Member

@xtreme-nitin-ravindran xtreme-nitin-ravindran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jpalermo jpalermo merged commit d718415 into develop Dec 4, 2024
5 checks passed
@jpalermo jpalermo deleted the handle-missing-dir-headers branch December 4, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants