Skip to content

Commit

Permalink
Merge pull request #40 from stat-kwon/master
Browse files Browse the repository at this point in the history
fix: apply deduplicated logic when creating and updating PrivateDashboard resource
  • Loading branch information
stat-kwon authored Dec 20, 2023
2 parents c01542b + b8f84a2 commit f3a4415
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions src/spaceone/dashboard/model/private_dashboard_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,9 @@ class PrivateDashboard(MongoModel):

@classmethod
def create(cls, data):
dashboard_vos = cls.filter(name=data["name"], domain_id=data["domain_id"])
dashboard_vos = cls.filter(
name=data["name"], user_id=data["user_id"], domain_id=data["domain_id"]
)

if dashboard_vos.count() > 0:
raise ERROR_NOT_UNIQUE(key="name", value=data["name"])
Expand All @@ -61,9 +63,10 @@ def create(cls, data):
def update(self, data):
if "name" in data:
dashboard_vos = self.filter(
private_dashboard_id__ne=self.private_dashboard_id,
name=data["name"],
domain_id=self.domain_id,
private_dashboard_id__ne=self.private_dashboard_id,
user_id=self.user_id,
)

if dashboard_vos.count() > 0:
Expand Down

0 comments on commit f3a4415

Please sign in to comment.