Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove service_account_id filed at AppInfo #306

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

yjinjo
Copy link
Contributor

@yjinjo yjinjo commented Apr 11, 2024

Category

  • New feature
  • Bug fix
  • Improvement
  • Refactor
  • etc

Description

Remove service_account_id filed at AppInfo

@yjinjo yjinjo added the enhancement New feature or request label Apr 11, 2024
@yjinjo yjinjo requested a review from ImMin5 April 11, 2024 12:39
@yjinjo yjinjo self-assigned this Apr 11, 2024
Copy link

⚠️ @yjinjo the signed-off-by was not found in the following 1 commits:

  • bd4f5e5: feat: remove service_account_id filed at AppInfo

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <[email protected]>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

@yjinjo yjinjo merged commit ff6a919 into cloudforet-io:master Apr 11, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fail/signedoff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant