Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Resource of identity for service account agent #281

Closed
wants to merge 4 commits into from

Conversation

yjinjo
Copy link
Contributor

@yjinjo yjinjo commented Mar 27, 2024

Category

  • New feature
  • Bug fix
  • Improvement
  • Refactor
  • etc

Description

With the development of the 'Service Account Agent' mode, the corresponding Protobuf has been added. Please refer to the service_account.proto and app.proto files.

@yjinjo yjinjo requested a review from ImMin5 March 27, 2024 05:47
Copy link

⚠️ @yjinjo the signed-off-by was not found in the following 2 commits:

  • fa13c16: feat: add new Resource of identity for service account agent
  • 2d6d0d8: chore: delete dist directory

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <[email protected]>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

Copy link

⚠️ @yjinjo the signed-off-by was not found in the following 4 commits:

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <[email protected]>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

@yjinjo yjinjo closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant