Skip to content
This repository has been archived by the owner on Jun 9, 2024. It is now read-only.

Fixed regression to 'File not ready yet' state #120

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed regression to 'File not ready yet' state #120

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
749426a
Fixed an issue that caused octorpki to return 'File not ready yet' af…
colinmcintosh Dec 8, 2022
576f39b
Set HasPreviousStable to true if MaxIterations is reached.
colinmcintosh Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cmd/octorpki/octorpki.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1251,7 +1251,9 @@ func (s *OctoRPKI) validationLoop() {
// Reduce
changed := s.MainReduce()
s.Stable.Store(!changed && s.stats.Iteration > 1)
s.HasPreviousStable.Store(s.Stable.Load())
if s.Stable.Load() {
s.HasPreviousStable.Store(s.Stable.Load())
}

if *Mode == "oneoff" && (s.Stable.Load() || !*WaitStable) {
s.mustOutput()
Expand All @@ -1265,6 +1267,7 @@ func (s *OctoRPKI) validationLoop() {
// GHSA-pmw9-567p-68pc: Do not crash when MaxIterations is reached
log.Warning("Max iterations has been reached. Defining current state as stable and stoppping deeper validation. This number can be adjusted with -max.iterations")
s.Stable.Store(true)
s.HasPreviousStable.Store(true)
}

if *Mode == "oneoff" && s.Stable.Load() {
Expand Down