x509 verify params + safety fixes #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kornelski
force-pushed
the
verify-param
branch
2 times, most recently
from
c8641d8 to
6a0cfb8
Compare
nox
reviewed
Nov 27, 2024
|
|
kornelski
force-pushed
the
verify-param
branch
from
8e29d65 to
ade1b67
Compare
rushilmehra
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've copied rust-openssl APIs that are needed to make c2pa.org SDK compatible with boring (jira IMAGES-1371).
The openssl crate had also a couple of important safety fixes —
X509VerifyParam::set_hostwith 0-len host was unsafe, andX509StoreRef::objectsreferences may get invalidated by other accesses of the shared cache.X509StoreRef::objectsis unfixable, so I've marked it asunsafeand deprecated, which is technically semver-breaking, but I think the risk of use-after-free in a safe API could warrant releasing it in 4.x despite breakage.