Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce X509CheckFlags::UNDERSCORE_WILDCARDS #204

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

nox
Copy link
Collaborator

@nox nox commented Dec 18, 2023

No description provided.

@nox nox force-pushed the underscore-wildcards branch 3 times, most recently from 2928982 to e799df8 Compare December 18, 2023 12:20
@nox nox force-pushed the underscore-wildcards branch from e799df8 to acc75e4 Compare December 20, 2023 16:55
Copy link

gitguardian bot commented Dec 20, 2023

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@nox nox force-pushed the underscore-wildcards branch 2 times, most recently from 066f1a3 to 968c6c7 Compare December 20, 2023 17:00
Copy link
Collaborator

@cbranch cbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed NO_PARTIAL_WILDCARDS preservation.

@nox
Copy link
Collaborator Author

nox commented Dec 20, 2023

Do not merge this! It conflicts with RPK support, I'll fix that after I'm back from PTO.

@nox nox force-pushed the underscore-wildcards branch from 968c6c7 to 502c231 Compare December 20, 2023 18:59
@nox nox merged commit a8dea4a into master Jan 2, 2024
23 checks passed
@nox nox deleted the underscore-wildcards branch January 2, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants