Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align with C-COMMON-TRAITS criteria #91

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Align with C-COMMON-TRAITS criteria #91

merged 2 commits into from
Oct 27, 2020

Conversation

slinkydeveloper
Copy link
Member

Aligned with C-COMMON-TRAITS criteria, part of #79

  • Implemented Eq for several public structs
  • Implemented Display for Event
  • Implemented Display for ExtensionValue
  • Removed bad implementation of ToString in MessageAttributeValue and replaced with implementation of Display

@slinkydeveloper
Fix C-COMMON-TRAITS
3e2af85 
Signed-off-by: Francesco Guardiani <[email protected]>
@slinkydeveloper
Fix C-COMMON-TRAITS
f116a6f 
Signed-off-by: Francesco Guardiani <[email protected]>
@slinkydeveloper slinkydeveloper added the enhancement New feature or request label Oct 21, 2020
@slinkydeveloper slinkydeveloper added this to the 0.3 milestone Oct 21, 2020
@slinkydeveloper slinkydeveloper mentioned this pull request Oct 21, 2020
Open
55 tasks
@slinkydeveloper slinkydeveloper merged commit d1281e7 into cloudevents:master Oct 27, 2020
@slinkydeveloper slinkydeveloper deleted the c-common-traits branch October 27, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.3
Development

Successfully merging this pull request may close these issues.
1 participant
@slinkydeveloper