Yield when closing consumers and channels

cloudamqp · Feb 13, 2025 · 7538965 · 7538965
1 parent 822c7ba
commit 7538965
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/lavinmq/amqp/channel.cr b/src/lavinmq/amqp/channel.cr
@@ -636,7 +636,10 @@ module LavinMQ
 
       def close
         @running = false
-        @consumers.each &.close
+        @consumers.each_with_index(1) do |consumer, i|
+          consumer.close
+          Fiber.yield if (i % 128) == 0
+        end
         @consumers.clear
         if drc = @direct_reply_consumer
           @client.vhost.direct_reply_consumers.delete(drc)

diff --git a/src/lavinmq/amqp/client.cr b/src/lavinmq/amqp/client.cr
@@ -410,7 +410,11 @@ module LavinMQ
 
       private def cleanup
         @running = false
-        @channels.each_value &.close
+        i = 0u32
+        @channels.each_value do |ch|
+          ch.close
+          Fiber.yield if (i &+= 1) % 512 == 0
+        end
         @channels.clear
         @exclusive_queues.each(&.close)
         @exclusive_queues.clear