Code Clean Up for Platfrom Controller #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SuyogShinde942 Will it be possible to squash the 6 commits into a single commit? |
|
sure |
SuyogShinde942
force-pushed
the
master
branch
3 times, most recently
from
cdbd3eb to
a68448b
Compare
Remove commented code for platformcontroller.go remove commented code remove commented code remove unused fucntions GetValuesTypes, getChartValueTypes,flatten remove unused imports Remove unused imports, functions, and references; clean up commented code for improved readability.
SuyogShinde942
force-pushed
the
master
branch
from
a68448b to
ccfc81a
Compare
|
@devdattakulkarni Can you please check this |
|
@SuyogShinde942 Looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issues #1371 and #1370:
Cleanup Unused Resource Policy Controller (#1371):
Removed the unused resourcepolicycontroller.go file.
Deleted commented-out references to resourcepolicycontroller in main.go, as it was never utilized.
Enhancements in Resource Composition Handling (#1370):
Improved PlatformController by ensuring the handleCRD method registers the CRD defined in the ResourceComposition spec.