Bulk upgrade test case #1230 #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Overall, looks good. I have added two in-line comments. Also, please remove pycache folder from the commit. |
|
@omgoswami ^^ |
|
Incorporated your suggestions! |
|
Looks like CI has failed: pip install is not able to find lxml. Try pinning it to a specific version. |
|
@omgoswami ^^ |
|
@omgoswami Tests are passing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test case that automatically checks that when a Helm chart in a ResourceComposition is updated, all running application instances also get upgraded. This was done by adapting the steps listed in https://github.com/cloud-ark/kubeplus/blob/master/examples/multitenancy/managed-service/appday2ops/steps.txt