Fix build/release issues #228
Conversation
Run deps only on kibit project, not on lein kibit.
TravisCI has problems building on OpenJDK 11 (which I do not have on AdoptOpenJDK 11). Maybe the problems are gone after upgrading (which I tend to like anyhow), so check.
- Test on OracleJDK 11 - Add Changelog plugin - Update Changelog
Add Badges and an Introduction on how to build Kibit
There was a problem hiding this comment.
Hey, thanks for the PR here, and splitting the commits up into small chunks. I'm slightly wary of taking on two new lein plugins for this, but will give it some thought. I know @arrdem has more experience with lein-monolith than I.
I've put some notes here on the PR, but please don't feel like you need to address them, it's mostly for myself.
| - "pushd kibit" | ||
| - "lein deps" | ||
| - "popd" | ||
| - "LEIN_USE_BOOTCLASSPATH=no lein cache-version" |
There was a problem hiding this comment.
I think LEIN_USE_BOOTCLASSPATH=no could be set once as an environment variable?
There was a problem hiding this comment.
Also, if we are going to add a makefile, can we use those make commands here?
| ### Additions | ||
| * Clojurescript/Cljx support (cljc support coming soon). This just works™, kibit will pick up your source paths from your `project.clj`'s `:source-paths`, `[:cljsbuild :builds]`, and `[:cljx :builds]`. | ||
| * Non-zero exit codes. Kibit now exits non-zero when one or more suggestions are made. This is particularly useful for those running checks in a CI environment. | ||
| * You can now run kibit on any Clojure project without a project.clj file. Just call `lein kibit` with any number of files and folders and it will inspect the Clojure files contained within. | ||
|
|
||
| [Unreleased]: https://github.com/gorillalabs/kibit/compare/v0.3.0...HEAD |
There was a problem hiding this comment.
Can you change gorrillalabs -> jonase here, and in the other places it was used?
| (slurp | ||
| (io/resource | ||
| "jonase/kibit/VERSION")))]] | ||
| kibit-version (clojure.edn/read-string |
There was a problem hiding this comment.
Can you match indentation here?
| "jonase/kibit/VERSION")))]] | ||
| kibit-version (clojure.edn/read-string | ||
| (slurp (io/resource "version.edn"))) | ||
| kibit-project `{:dependencies [[gorillalabs/kibit ~(:version kibit-version)]] |
There was a problem hiding this comment.
Would be neat if lein-v could also print out the group and artifact ID, so it didn't need to be hard-coded here.
| (io/resource | ||
| "jonase/kibit/VERSION")))]] | ||
| kibit-version (clojure.edn/read-string | ||
| (slurp (io/resource "version.edn"))) |
There was a problem hiding this comment.
If any user of kibit has a file called version.edn at the root of their classpath then there will be conflicts between this one and that one. It would be good to be able to move it to jonase/kibit/version.edn to avoid the risk of conflicts.
|
Any update on this? I think it fixes #229 |
|
I've got a bunch of review comments that are blocking merging of this PR. I'll do a separate release though. |
|
Closing due to lack of movement. |
Hi,
for building a release containing your latest commits/PRs (#222), I needed to setup and build my own version of kibit.
I fixed some issues you might want to copy over to your project.
lein release :patchto actually release a new version)Feel free to take whatever you like and dismiss everything else.
This change is