Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy crawler to production azure #602

Closed
wants to merge 29 commits into from

Conversation

ljones140
Copy link
Contributor

@ljones140 ljones140 commented Sep 30, 2024

What

Add's workflow that deploys a production crawler to Clearly Defineds Azure

DO NOT MERGE:

This is part of project to have Crawlers running on CD Azure as well as MSFT.

Currently the cdcrawler-prod that this workflow deploys is pointed at development azblob. To test deploy works.
After test we need to make additional changes so this workflow also publishes production image to Docker Hub as MSFT and GitHub are using.

@ljones140 ljones140 marked this pull request as draft September 30, 2024 13:37
@jeffmendoza
Copy link
Member

@ljones140
Copy link
Contributor Author

Is using OIDC a possibility for us to move away from credential secrets? https://docs.github.com/en/actions/security-for-github-actions/security-hardening-your-deployments/configuring-openid-connect-in-azure

Yes that should work.

We log into Azure here in the base operations workflow https://github.com/clearlydefined/operations/blob/main/.github/workflows/app-deploy-to-azure.yml#L52-L55

Not sure if I can do as part of this task. But can create an issue on operations for this change.

@ljones140
Copy link
Contributor Author

Closing in favour of #608

@ljones140 ljones140 closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants