add sha and version to ‘/‘ endpoint #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumaxis
reviewed
May 14, 2024
Comment on lines
+13
to
+19
| let version | ||
| let sha | ||
| function setup(buildsha, appVersion) { | ||
| version = appVersion | ||
| sha = buildsha | ||
| return router | ||
| } |
There was a problem hiding this comment.
This works but I'm not sure how well I like keeping the values as global state in this file. Couldn't we just access the config directly here instead of passing as variables?
Additionally, I'm wondering if it'd be worth to still escape these values, even though they should usually be under our control.
There was a problem hiding this comment.
The style matches that used in other endpoints. I'm open to other options.
elrayle
force-pushed
the
elr/ver-sha
branch
from
13cf5c3 to
ce50ee8
Compare
This was referenced Sep 30, 2024
ljones140
reviewed
Oct 2, 2024
| @@ -23,7 +23,7 @@ jobs: | |||
| build-and-deploy: | |||
| name: Build and Deploy | |||
| needs: upload-package-lock-json | |||
| uses: clearlydefined/operations/.github/workflows/app-build-and-deploy.yml@v2.0.0 | |||
| uses: clearlydefined/operations/.github/workflows/app-build-and-deploy.yml@0a6c2607470e2e0e49bf2d6636223bcd62c1a7f8 | |||
There was a problem hiding this comment.
Needs to be changed once operations PR merged
APP_VERSION replaces it
RomanIakovlev
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add configurations for
BUILD_SHAandAPP_VERSIONto use for debugging.Related Work
Unresolved
The deploy isn't happening through the reusable workflows that would set these configs. Additionally, it is not clear how deploys are happening in the current Azure DevOps deploy. Some investigation is needed before merging.