Update PodExtract tool version #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
qtomlinson
commented
Apr 10, 2024
•
qtomlinson
commented
- Add unit tests for verification purposes.
- Refactor toolVersion in PodExtract. Reasons in commit message
- The recent fix to exclude content in the .git directory (Exclude .git directory content when calculating package file count #525) from pod packages will cause the file count to be different from the previous version. Update the toolVersion for PodExtract to 2.0.0 to reflect this.
document._metadata.links.self.href is used in construct file path or blob name when storing the harvested data. It should reflect the _schemaVersion of PodExtract. Added test to verify this.
1. In AbstractProcessor, _schemaVersion is the combination of schemaVersion or toolVersion along the class hierarchy. 2. Most component related processors, e.g. mavenExtract or npmExtract, which are subClasses of abstractClealyDefinedProcessors, overrride toolVersion(), see comments at AbstractProcessor.toolVersion(). This convention was introduced in commit "isolate toolVersion from schemaVersion". The exception is PodExtract. This commit aligns PodExtract with the rest of the component related processors.
This is for fix to exclude .git directory content in recent PR (clearlydefined#525). Bump up the version to allow reharvest of pod components.
The recent fix to exclude content in the .git directory (clearlydefined#525) from pod packages will cause the file count to be different from the previous version. Update the toolVersion for PodExtract to 2.0.0 to reflect this.
lumaxis
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.