Remove rimraf #558
Merged
Remove rimraf #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since node v14.14.0, there is fsPromises.rm. "To get a behavior similar to the rm -rf Unix command, use fsPromises.rm() with options { recursive: true, force: true }." Might be better in terms of future maintenance? |
|
@qtomlinson Nice! Much easier 🙂 |
qtomlinson
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating
rimrafto the latest version requires a small code change due to the change in how the library handles its exports (there is no default export anymore), plus it now supports Promises natively by default, hence we don't need to manually resolve and reject anymore.