Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve formatting and linting setup #538

Merged
merged 11 commits into from
May 6, 2024

Conversation

lumaxis
Copy link
Contributor

@lumaxis lumaxis commented Jan 18, 2024

I stumbled over the confusingly leftover .prettierrc and took a quick look at the ESLint setup. It's now updated to the latest version and the config updated to allow ECMA version syntax and features that should closely match Node 18.

@qtomlinson
Copy link
Collaborator

qtomlinson commented Jan 25, 2024

Thanks for updating eslint! With eslint deprecate formatting rules, it maybe worthwhile to keep a formatter (e.g. prettier or other) in place for consistent formatting in the code base. Any thoughts?

@lumaxis lumaxis changed the title Update ESLint to latest version Improve formatting and linting setup Jan 29, 2024
@lumaxis
Copy link
Contributor Author

lumaxis commented Jan 29, 2024

@qtomlinson @elrayle I've taken on the suggestion to keep Prettier and improved the project setup so it is properly integrated now and e.g. runs automatically in CI and has good editor integration with VS Code.

The PR now also includes a commit that fixes all previous issues that Prettier fixes, so it might be easier to review this commit by commit.

Additionally, I'd suggest to only merge this after #532, so that that doesn't have to resolve a bunch of formatting issues.

Let me know what you think! If we like this setup, I'd be happy to port it to the service and website repos eventually, too.

@lumaxis lumaxis requested review from qtomlinson and elrayle January 29, 2024 14:24
.prettierrc.json Outdated Show resolved Hide resolved
@qtomlinson
Copy link
Collaborator

This will definitely help to ensure consistency in the code base. Thanks for putting this together!

@lumaxis
Copy link
Contributor Author

lumaxis commented Jan 31, 2024

As mentioned above, I'll hold off merging this until #532 is in to avoid any conflict issues 🙏🏼

@lumaxis lumaxis merged commit 473a560 into clearlydefined:master May 6, 2024
1 check passed
@lumaxis lumaxis deleted the update-eslint branch May 6, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants