-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve formatting and linting setup #538
Conversation
b256526
to
77e7ce0
Compare
Thanks for updating eslint! With eslint deprecate formatting rules, it maybe worthwhile to keep a formatter (e.g. prettier or other) in place for consistent formatting in the code base. Any thoughts? |
@qtomlinson @elrayle I've taken on the suggestion to keep Prettier and improved the project setup so it is properly integrated now and e.g. runs automatically in CI and has good editor integration with VS Code. The PR now also includes a commit that fixes all previous issues that Prettier fixes, so it might be easier to review this commit by commit. Additionally, I'd suggest to only merge this after #532, so that that doesn't have to resolve a bunch of formatting issues. Let me know what you think! If we like this setup, I'd be happy to port it to the service and website repos eventually, too. |
This will definitely help to ensure consistency in the code base. Thanks for putting this together! |
20e2659
to
f22c847
Compare
As mentioned above, I'll hold off merging this until #532 is in to avoid any conflict issues 🙏🏼 |
This reverts commit a0fc329.
I stumbled over the confusingly leftover
.prettierrc
and took a quick look at the ESLint setup. It's now updated to the latest version and the config updated to allow ECMA version syntax and features that should closely match Node 18.