Add handling of simple

lib/fetch.js

@@ -11,23 +11,31 @@ function buildRequestOptions(request) {
     responseType = 'stream'
   }
 
+  const validateOptions = {}
+  if (!request.simple) {
+    validateOptions.validateStatus = () => true
+  }
+
   return {
     method: request.method,
     url: request.url,
     responseType,
     headers: request.headers,
-    data: request.body
+    data: request.body,
+    ...validateOptions
   }
 }
 
 async function callFetch(request, axiosInstance = axios) {
   try {
     const options = buildRequestOptions(request)
     const response = await axiosInstance(options)
-    if (request.resolveWithFullResponse) return response
-    return response.data
+    if (!request.resolveWithFullResponse) return response.data
+    response.statusCode = response.status
+    response.statusMessage = response.statusText
+    return response
   } catch (error) {
-    if (error.response && request.resolveWithFullResponse) return error.response
+    error.statusCode = error.response?.status
     throw error
   }
 }

test/unit/lib/fetchTests.js

@@ -32,22 +32,22 @@ describe('CallFetch', () => {
         method: 'GET',
         resolveWithFullResponse: true
       })
-      expect(response.status).to.be.equal(200)
-      expect(response.statusText).to.be.equal('OK')
+      expect(response.statusCode).to.be.equal(200)
+      expect(response.statusMessage).to.be.equal('OK')
     })
 
-    it('checks if the full response is fetched with error code', async () => {
+    it('should throw error with error code', async () => {
       const path = '/registry.npmjs.com/redis/0.1.'
       await mockServer.forGet(path).thenReply(404)
 
-      const response = await callFetch({
+      await callFetch({
         url: mockServer.urlFor(path),
         method: 'GET',
         json: 'true',
         resolveWithFullResponse: true
+      }).catch(err => {
+        expect(err.statusCode).to.be.equal(404)
       })
-      expect(response.status).to.be.equal(404)
-      expect(response.statusText).to.be.equal('Not Found')
     })
 
     it('checks if the response is text while sending GET request', async () => {
@@ -96,6 +96,43 @@ describe('CallFetch', () => {
       expect(requests[1].url).to.equal(url)
       expect(requests[1].headers).to.include(defaultOptions.headers)
     })
+
+    describe('test simple', () => {
+      it('should handle 300 when simple is true by default', async () => {
+        const path = '/registry.npmjs.com/redis/0.1.0'
+        await mockServer.forGet(path).thenReply(300, 'test')
+
+        await callFetch({
+          url: mockServer.urlFor(path)
+        }).catch(err => {
+          expect(err.statusCode).to.be.equal(300)
+        })
+      })
+
+      it('should handle 300 with simple === false', async () => {
+        const path = '/registry.npmjs.com/redis/0.1.0'
+        await mockServer.forGet(path).thenReply(300, 'test')
+
+        const response = await callFetch({
+          url: mockServer.urlFor(path),
+          simple: false
+        })
+        expect(response).to.be.equal('test')
+      })
+
+      it('should return status 300 with simple === false', async () => {
+        const path = '/registry.npmjs.com/redis/0.1.0'
+        await mockServer.forGet(path).thenReply(300, 'test')
+
+        const response = await callFetch({
+          url: mockServer.urlFor(path),
+          simple: false,
+          resolveWithFullResponse: true
+        })
+        expect(response.statusCode).to.be.equal(300)
+        expect(response.statusMessage).to.be.equal('Multiple Choices')
+      })
+    })
   })
 
   describe('test crate download', () => {