-
Notifications
You must be signed in to change notification settings - Fork 32
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #1 from qtomlinson/qt/pull_fetch
Qt/pull fetch
- Loading branch information
Showing
6 changed files
with
220 additions
and
74 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,70 +1,165 @@ | ||
| const { callFetch } = require('../../../lib/fetch') | ||
| const { callFetch, withDefaults } = require('../../../lib/fetch') | ||
| const { expect } = require('chai') | ||
| const fs = require('fs') | ||
| const mockttp = require('mockttp') | ||
|
|
||
| describe('CallFetch', () => { | ||
| it('checks if the response is JSON while sending GET request', async () => { | ||
| const response = await callFetch({ | ||
| url: 'https://registry.npmjs.com/redis/0.1.0', | ||
| method: 'GET', | ||
| responseType: 'json' | ||
| describe('with mock server', () => { | ||
| const mockServer = mockttp.getLocal() | ||
| beforeEach(async () => await mockServer.start()) | ||
| afterEach(async () => await mockServer.stop()) | ||
|
|
||
| it('checks if the response is JSON while sending GET request', async () => { | ||
| const path = '/registry.npmjs.com/redis/0.1.0' | ||
| const expected = fs.readFileSync('test/fixtures/fetch/redis-0.1.0.json') | ||
| await mockServer.forGet(path).thenReply(200, expected) | ||
|
|
||
| const response = await callFetch({ | ||
| url: mockServer.urlFor(path), | ||
| method: 'GET', | ||
| json: true | ||
| }) | ||
| expect(response).to.be.deep.equal(JSON.parse(expected)) | ||
| }) | ||
| expect(response).to.be.deep.equal(JSON.parse(fs.readFileSync('test/fixtures/fetch/redis-0.1.0.json'))) | ||
| }) | ||
|
|
||
| it('checks if the full response is fetched', async () => { | ||
| const response = await callFetch({ | ||
| url: 'https://registry.npmjs.com/redis/0.1.0', | ||
| method: 'GET', | ||
| responseType: 'json', | ||
| resolveWithFullResponse: true | ||
| it('checks if the full response is fetched', async () => { | ||
| const path = '/registry.npmjs.com/redis/0.1.0' | ||
| const expected = fs.readFileSync('test/fixtures/fetch/redis-0.1.0.json') | ||
| await mockServer.forGet(path).thenReply(200, expected) | ||
|
|
||
| const response = await callFetch({ | ||
| url: mockServer.urlFor(path), | ||
| method: 'GET', | ||
| resolveWithFullResponse: true | ||
| }) | ||
| expect(response.statusCode).to.be.equal(200) | ||
| expect(response.statusMessage).to.be.equal('OK') | ||
| }) | ||
| expect(response.status).to.be.equal(200) | ||
| expect(response.statusText).to.be.equal('OK') | ||
| }) | ||
|
|
||
| it('checks if the full response is fetched with error code', async () => { | ||
| const response = await callFetch({ | ||
| url: 'https://registry.npmjs.com/redis/0.', | ||
| method: 'GET', | ||
| responseType: 'json', | ||
| resolveWithFullResponse: true | ||
| it('should throw error with error code', async () => { | ||
| const path = '/registry.npmjs.com/redis/0.1.' | ||
| await mockServer.forGet(path).thenReply(404) | ||
|
|
||
| await callFetch({ | ||
| url: mockServer.urlFor(path), | ||
| method: 'GET', | ||
| json: 'true', | ||
| resolveWithFullResponse: true | ||
| }).catch(err => { | ||
| expect(err.statusCode).to.be.equal(404) | ||
| }) | ||
| }) | ||
| expect(response.status).to.be.equal(404) | ||
| expect(response.statusText).to.be.equal('Not Found') | ||
| }) | ||
|
|
||
| it('checks if the response is text while sending GET request', async () => { | ||
| const response = await callFetch({ | ||
| url: 'https://proxy.golang.org/rsc.io/quote/@v/v1.3.0.mod', | ||
| method: 'GET', | ||
| responseType: 'text' | ||
| it('checks if the response is text while sending GET request', async () => { | ||
| const path = '/proxy.golang.org/rsc.io/quote/@v/v1.3.0.mod' | ||
| await mockServer.forGet(path).thenReply(200, 'module "rsc.io/quote"\n') | ||
|
|
||
| const response = await callFetch({ | ||
| url: mockServer.urlFor(path), | ||
| method: 'GET' | ||
| }) | ||
| expect(response).to.be.equal('module "rsc.io/quote"\n') | ||
| }) | ||
| expect(response).to.be.equal('module "rsc.io/quote"\n') | ||
| }) | ||
|
|
||
| //This test case downloads a crate package | ||
| //This URL would send a JSON response if the header is not provided as a part of request. | ||
| it('should follow redirect and download the package when responseType is stream', async () => { | ||
| const response = await callFetch({ | ||
| url: 'https://crates.io/api/v1/crates/bitflags/1.0.4/download', | ||
| method: 'GET', | ||
| responseType: 'stream', | ||
| headers: { | ||
| Accept: 'text/html' | ||
| } | ||
| it('should download stream successfully with GET request', async () => { | ||
| const expected = JSON.parse(fs.readFileSync('test/fixtures/fetch/redis-0.1.0.json')) | ||
| const path = '/registry.npmjs.com/redis/0.1.0' | ||
| await mockServer.forGet(path).thenStream(200, fs.createReadStream('test/fixtures/fetch/redis-0.1.0.json')) | ||
|
|
||
| const response = await callFetch({ | ||
| url: mockServer.urlFor(path), | ||
| encode: null | ||
| }) | ||
| const destination = 'test/fixtures/fetch/temp.json' | ||
| await new Promise((resolve) => { | ||
| response.pipe(fs.createWriteStream(destination).on('finish', () => resolve(true))) | ||
| }) | ||
| const downloaded = JSON.parse(fs.readFileSync(destination)) | ||
| expect(downloaded).to.be.deep.equal(expected) | ||
| fs.unlinkSync(destination) | ||
| }) | ||
|
|
||
| it('should apply default headers ', async () => { | ||
| const path = '/registry.npmjs.com/redis/0.1.0' | ||
| const url = mockServer.urlFor(path) | ||
| const endpointMock = await mockServer.forGet(path).thenReply(200) | ||
|
|
||
| const defaultOptions = { headers: { 'user-agent': 'clearlydefined.io crawler ([email protected])' } } | ||
| const requestWithDefaults = withDefaults(defaultOptions) | ||
| await requestWithDefaults({ url }) | ||
| await requestWithDefaults({ url }) | ||
|
|
||
| const requests = await endpointMock.getSeenRequests() | ||
| expect(requests.length).to.equal(2) | ||
| expect(requests[0].url).to.equal(url) | ||
| expect(requests[0].headers).to.include(defaultOptions.headers) | ||
| expect(requests[1].url).to.equal(url) | ||
| expect(requests[1].headers).to.include(defaultOptions.headers) | ||
| }) | ||
|
|
||
| describe('test simple', () => { | ||
| it('should handle 300 when simple is true by default', async () => { | ||
| const path = '/registry.npmjs.com/redis/0.1.0' | ||
| await mockServer.forGet(path).thenReply(300, 'test') | ||
|
|
||
| await callFetch({ | ||
| url: mockServer.urlFor(path) | ||
| }).catch(err => { | ||
| expect(err.statusCode).to.be.equal(300) | ||
| }) | ||
| }) | ||
|
|
||
| it('should handle 300 with simple === false', async () => { | ||
| const path = '/registry.npmjs.com/redis/0.1.0' | ||
| await mockServer.forGet(path).thenReply(300, 'test') | ||
|
|
||
| const response = await callFetch({ | ||
| url: mockServer.urlFor(path), | ||
| simple: false | ||
| }) | ||
| expect(response).to.be.equal('test') | ||
| }) | ||
|
|
||
| it('should return status 300 with simple === false', async () => { | ||
| const path = '/registry.npmjs.com/redis/0.1.0' | ||
| await mockServer.forGet(path).thenReply(300, 'test') | ||
|
|
||
| const response = await callFetch({ | ||
| url: mockServer.urlFor(path), | ||
| simple: false, | ||
| resolveWithFullResponse: true | ||
| }) | ||
| expect(response.statusCode).to.be.equal(300) | ||
| expect(response.statusMessage).to.be.equal('Multiple Choices') | ||
| }) | ||
| }) | ||
| //Validating the length of the content inorder to verify the response is a crate package. | ||
| // JSON response would not return this header in response resulting in failing this test case. | ||
| expect(response.headers['content-length']).to.be.equal('15282') | ||
| }) | ||
|
|
||
| it('should follow redirect and download the package when responseType is stream', async () => { | ||
| const response = await callFetch({ | ||
| url: 'https://static.crates.io/crates/bitflags/bitflags-1.0.4.crate', | ||
| method: 'GET', | ||
| responseType: 'stream' | ||
| describe('test crate download', () => { | ||
| // This test case downloads a crate package | ||
| // This URL would send a JSON response if the header is not provided as a part of request. | ||
| it('should follow redirect and download the package when responseType is stream', async () => { | ||
| const response = await callFetch({ | ||
| url: 'https://crates.io/api/v1/crates/bitflags/1.0.4/download', | ||
| method: 'GET', | ||
| encode: null, | ||
| headers: { | ||
| Accept: 'text/html' | ||
| } | ||
| }) | ||
| // Validating the length of the content in order to verify the response is a crate package. | ||
| // JSON response would not return this header in response resulting in failing this test case. | ||
| expect(response.headers['content-length']).to.be.equal('15282') | ||
| }) | ||
|
|
||
| it('should download the package when responseType is stream', async () => { | ||
| const response = await callFetch({ | ||
| url: 'https://static.crates.io/crates/bitflags/bitflags-1.0.4.crate', | ||
| method: 'GET', | ||
| encode: null | ||
| }) | ||
| // Validating the length of the content inorder to verify the response is a crate package. | ||
| expect(response.headers['content-length']).to.be.equal('15282') | ||
| }) | ||
| //Validating the length of the content inorder to verify the response is a crate package. | ||
| expect(response.headers['content-length']).to.be.equal('15282') | ||
| }) | ||
| }) |
Oops, something went wrong.