Add consistency between verify and verify --fix #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests look good to me |
This commit adds some tests to validate consistency between "swupd verify" and "swupd verify --fix". Signed-off-by: Castulo Martinez <[email protected]>
Running "swupd verify" should be a dry-run of running "swupd verify --fix", meaning that "swupd verify" should find the same issues to be resolved than "swupd verify --fix" but it should just inform about them while --fix should inform + fix them. In occasions this does not happen, for example when there are tracked files that need to be removed from the system. This commit fixes that. Signed-off-by: Castulo Martinez <[email protected]>
otaviobp
approved these changes
Nov 12, 2018
evil-brain
approved these changes
Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running "swupd verify" should be a dry-run of running
"swupd verify --fix", meaning that "swupd verify" should find
the same issues to be resolved than "swupd verify --fix" but it
should just inform about them while --fix should inform + fix them.
In occasions this does not happen, for example when there are
tracked files that need to be removed from the system.
Closes #607
Closes #536
Signed-off-by: Castulo Martinez [email protected]