Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating with logic for expire token #45

Merged
merged 73 commits into from
Aug 16, 2024

Conversation

jboucourt
Copy link
Contributor

@jboucourt jboucourt commented Aug 5, 2024

Summary

There are issues when vault token expires mainly for jobs running in temporal. We are updating the lib to check when the token is about to expire and proactively reconnect to obtain a new token. New tokens have a ttl of 32 days, our logic is to reconnect 5 days before expire time.

Testing

Check one of the following boxes once you've 1) completed testing and added a description of the test below or 2) added a description for why testing isn't needed.

  • This change has been tested and a description of the test(s) performed has been added in accordance with Clear Street's testing policy.
  • Testing has not been performed and a description of why has been added.

Description of Testing:

I have tested locally, creating a policy on vault and executing the logic.

How-to Updating gestalt: https://www.notion.so/clearstreet/Updating-Gestalt-7b09f58cdf4c4344a28b5e059d1dc222

gestalt/vault.py Outdated Show resolved Hide resolved
gestalt/vault.py Outdated Show resolved Hide resolved
gestalt/vault.py Outdated Show resolved Hide resolved
gestalt/vault.py Outdated Show resolved Hide resolved
gestalt/vault.py Outdated Show resolved Hide resolved
gestalt/vault.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
gestalt/vault.py Show resolved Hide resolved
@jboucourt jboucourt merged commit 7a259a8 into master Aug 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants