Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add converter to smolagents tool #8

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Add converter to smolagents tool #8

merged 1 commit into from
Jan 24, 2025

Conversation

anishathalye
Copy link
Member

a smol PR to add support for smolagents

@anishathalye anishathalye requested a review from axl1313 January 22, 2025 23:13
@anishathalye anishathalye force-pushed the smolagents-tool branch 2 times, most recently from 6ce0f68 to 544d77b Compare January 22, 2025 23:43
@anishathalye
Copy link
Member Author

CI is failing because of coverage report --fail-under=90. smolagents is Python 3.10+, so that test will only run on that platform.

How do you want to handle this?

@axl1313
Copy link
Collaborator

axl1313 commented Jan 23, 2025

CI is failing because of coverage report --fail-under=90. smolagents is Python 3.10+, so that test will only run on that platform.

How do you want to handle this?

Ah we can probably just run minimum coverage check for latest Python version. Let me set that up

Copy link
Collaborator

@axl1313 axl1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! i just updated CI to only run coverage with the --fail-under flag for Python 3.13, so if you merge main into this branch, it should pass now.

@anishathalye anishathalye merged commit e215c21 into main Jan 24, 2025
8 checks passed
@anishathalye anishathalye deleted the smolagents-tool branch January 24, 2025 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants