Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update comments and types for generating python API reference #38

Merged
merged 6 commits into from
Feb 18, 2025

Conversation

kelsey-wong
Copy link
Contributor

@kelsey-wong kelsey-wong commented Feb 14, 2025

Add/update docstrings so they look better for the Python API Reference section of our docs site

@kelsey-wong kelsey-wong marked this pull request as ready for review February 15, 2025 00:15
@kelsey-wong
Copy link
Contributor Author

@axl1313 I want to make some small updates to the docstrings here so that they'll be better on the docs site, but how do I actually flow these changes forward to the docs site? Do I need to tag and publish a new version of the library?

@axl1313
Copy link
Collaborator

axl1313 commented Feb 15, 2025

@axl1313 I want to make some small updates to the docstrings here so that they'll be better on the docs site, but how do I actually flow these changes forward to the docs site? Do I need to tag and publish a new version of the library?

Yup currently will need to tag and release a new version to trigger the docs rebuild.

@kelsey-wong kelsey-wong requested a review from axl1313 February 15, 2025 00:32
Comment on lines 55 to 57
sdk_client (`Codex`): The Codex SDK client to use to interact with the project.
project_id (`str`): The ID of the project.
verify_existence (`bool`, optional): Whether to verify that the project exists.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: for consistency across the docs can we remove the backticks around the types for args? The generated docs apply {arg_name} formatting around the argument name already, so having the arg type formatted as code too looks a little weird

@axl1313 axl1313 merged commit 85dbad7 into main Feb 18, 2025
8 checks passed
@kelsey-wong kelsey-wong deleted the fix-docs branch February 18, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants