-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix model validation in pydantic; #27
Conversation
Are you sure updating Pydantic will resolve this? I just installed it in a fresh environment and checked the version, but still ran into this validation error: pip freeze | grep pydantic
# pydantic==2.10.6 I suspect the issue might be due to the Reference:
@aditya1503 Any reason why you reverted your suggested |
This reverts commit 89647dc.
reverted, I fixed the unit test case that was failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix! i pushed some additional changes to the tests that would actually have caught this issue as well. the mocking in the test cases was flawed before.
Fix validation error in Pydantic: