-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add workflow for publishing releases #19
Conversation
19a0716
to
68656a4
Compare
68656a4
to
afa2796
Compare
[Unreleased]: https://github.com/cleanlab/cleanlab-codex/compare/v0.0.1a1...HEAD | ||
[0.0.1a1]: https://github.com/cleanlab/cleanlab-codex/compare/267a93300f77c94e215d7697223931e7926cad9e...v0.0.1a1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@axl1313 do these links need to be manually updated as well? (I'm bumping the version in my refactor PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question! Yeah they do. It'll just be updating the base commit for the [Unreleased] link to the new version tag and adding a link underneath the [Unreleased] link for the new version. Mind updating the DEVELOPMENT.md to mention this as well :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep I'll update DEVELOPMENT.md too! to confirm - I need to merge my PR first, and then create a 2nd PR to bump the version, right? because otherwise I won't have the squashed commit ID to reference in the link for my new version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you could do it as part of the same PR, since the link uses the tag rather than the actual commit hash. The link will just be broken for a little until you push the new tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah good call! I updated it in my branch
__about__.py