Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

youtube component #20

Open
wants to merge 49 commits into
base: master
Choose a base branch
from
Open

youtube component #20

wants to merge 49 commits into from

Conversation

jeanrodriguez
Copy link
Contributor

@jeanrodriguez jeanrodriguez commented Mar 8, 2019 •
edited
Loading

Description

  • Added youtube component to clay-starter

Screen Shot 2019-03-13 at 3 17 47 PM

@jeanrodriguez
component youtube
9a021df
@jeanrodriguez
added new files for twitter component
732019b
@jeanrodriguez
youtube component
b6b99f1
@jeanrodriguez
Create youtube.css
03770ca
@jeanrodriguez
added youtube video player js
aa83fc3
@jeanrodriguez
yotube component
a20a5bb
@jeanrodriguez
youtube component _layout and _component
69379a6
@jeanrodriguez
fix css
c10b45e
@jeanrodriguez
added YOUTUBE_API_KEY env variable, remove unuse css
858397e
@jeanrodriguez
Revert "added YOUTUBE_API_KEY env variable, remove unuse css"
f42ee11 
This reverts commit 858397e.
@jeanrodriguez
fix css and add env variable
5358dc6
@jeanrodriguez
added YOUTUBE_API_KEY
21b8185
@jeanrodriguez
Update schema.yaml
b36e19a
@jeanrodriguez
remove unnecesary description. update youtube css
ab1db28
@jeanrodriguez
Update client.js
8ddcc6f
@jeanrodriguez
remove unused functions
9f192f9
@jeanrodriguez
Update visibility.js
cf79110
@jeanrodriguez
removed getViewportHeight
5abe5ce
@jeanrodriguez
Update visibility.js
e468746
@jeanrodriguez
removed _assign visbility.js
8dd8f1c
@jeanrodriguez
Update gtm.js
52b9202
@jeanrodriguez
remove unused code visibility and gtm js
3ec66f5
@jeanrodriguez
remove unused files
d529ab6
@jeanrodriguez
Update youtube-video-player.js
b587e7d
@jeanrodriguez
Update youtube.js
86a4ac4
@jeanrodriguez
update byline removed join and map lodash
fc5c953
@jeanrodriguez
Update byline.js
0269a5c
@jeanrodriguez
Merge branch 'master' of https://github.com/clay/clay-starter into co…
01540b7 
…de-component-youtube
@jeanrodriguez
youtube component for clay-starter
69208b0
@jeanrodriguez
Merge branch 'code-component-youtube' of https://github.com/clay/clay…
fa81bda 
…-starter into code-component-youtube
manuelurenah
manuelurenah reviewed Mar 12, 2019
View reviewed changes
app/components/youtube-player-head/template.hbs Show resolved Hide resolved
app/components/youtube/client.js Outdated Show resolved Hide resolved
app/components/youtube/client.js Outdated Show resolved Hide resolved
app/components/youtube/client.js Outdated Show resolved Hide resolved
app/components/youtube/model.js Show resolved Hide resolved
app/components/youtube/model.js Outdated Show resolved Hide resolved
app/components/youtube/model.js Outdated Show resolved Hide resolved
app/services/client/visibility.js Outdated Show resolved Hide resolved
app/services/universal/youtube.js Show resolved Hide resolved
@jeanrodriguez jeanrodriguez changed the title WIP: component youtube youtube component Mar 13, 2019
manuelurenah
manuelurenah reviewed Mar 13, 2019
View reviewed changes
app/components/youtube/client.js Outdated Show resolved Hide resolved
app/components/youtube/client.js Outdated Show resolved Hide resolved
app/services/universal/byline.js Outdated Show resolved Hide resolved
app/services/universal/youtube-video-player.js Outdated Show resolved Hide resolved
@jeanrodriguez jeanrodriguez force-pushed the code-component-youtube branch 3 times, most recently from 02d55f9 to 94eb947 Compare March 13, 2019 22:07
@jeanrodriguez jeanrodriguez self-assigned this Mar 13, 2019
@jeanrodriguez jeanrodriguez force-pushed the code-component-youtube branch 2 times, most recently from 7055a13 to dbac03e Compare March 14, 2019 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelurenah manuelurenah manuelurenah left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@jeanrodriguez jeanrodriguez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeanrodriguez @manuelurenah