🍕 Add preventAuth parameter #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-owen
reviewed
Feb 6, 2025
index.js
Outdated
| @@ -39,6 +39,9 @@ function isProtectedRoute(req) { | |||
| */ | |||
| function isAuthenticated(site) { | |||
| return function (req, res, next) { | |||
| // eslint-disable-next-line no-constant-condition | |||
| if (process.env.PREVENT_AUTH || true) return res.redirect(`${getAuthUrl(site)}/login`); | |||
There was a problem hiding this comment.
Could you add this here?
Line 4 in fe2025c
jjpaulino
commented
Feb 7, 2025
| @@ -102,12 +102,6 @@ workflows: | |||
| version: 2 | |||
| test: | |||
| jobs: | |||
| - test_node10: | |||
There was a problem hiding this comment.
Removing the circleci files so it doesn't fail and notify everyone who's listening lol
I'll add an issue to redo this with github actions.
jjpaulino
commented
Feb 7, 2025
| @@ -4,6 +4,15 @@ | |||
| <meta charset="utf-8"> | |||
| <title>Log In - Clay</title> | |||
| <style> | |||
| @keyframes fadeIn { | |||
There was a problem hiding this comment.
Added a small animation to the maintenance message just because.
jjpaulino
commented
Feb 7, 2025
| localAuthPath: `${authUrl}/local`, | ||
| useLocalAuth: providers.includes('local') | ||
| logoutLink: `${authUrl}/logout`, |
There was a problem hiding this comment.
Re-ordered alphabetically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a flag that, when true, will prevent users from either going into edit mode or making any edits to a page they had already opened in edit mode in their browsers. This environment variable is optional and you can set it up from your Clay instance and it'll be picked up here since it'll share the same env file!