-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gauge filenames #293
Gauge filenames #293
Conversation
I tried modifying the The 2D and 3D works for me. Do you want to add the 1D and we can merge this? |
@mandli, For some reason I thought we didn't have gauges implemented in 1d amrclaw, but I guess it does. I can go ahead and add this. By the way, when testing 3d gauges I found that |
I notice that |
I keep getting that |
@mandli: Yes, that's what I get too, also on the master branch and with v5.10.0. I haven't tried reverting to earlier versions, but I don't think that example or the Riemann solver has changed in years. |
@rjleveque Looking at the history this was clearly my fault. There is a missing
I am not sure what the correct solution is here though and the gauges are all unremarkable so I am not sure what we are supposed to see. |
I'm going to merge this and then will do a separate PR for the |
Same changes as in clawpack/geoclaw#615, and now allows gauge number up to 9 digits (actually up to
2**31 - 1 = 2147483647
since it is stored as an 4-byte integer).