Bump dependency versions #1949
Merged
Bump dependency versions #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see the failure. I will add the |
martijnbastiaan
force-pushed
the
bump-dep-versions
branch
from
2282ac4 to
55ec75d
Compare
alex-mckenna
approved these changes
Oct 11, 2021
| parseWithRead field obj = do | ||
| v <- obj .:? field | ||
| case readMaybe =<< v of | ||
| Just a -> pure a | ||
| Nothing -> fail $ "Could not read field: " <> Text.unpack field | ||
| Nothing -> fail $ "Could not read field: " <> show field |
There was a problem hiding this comment.
Why this change? Do you want quotation marks around the field name?
There was a problem hiding this comment.
It was a low-effort / good-enough fix for aeson moving to their Key datatype (as opposed to Text).
mergify bot
pushed a commit
that referenced
this pull request
Oct 11, 2021
Related: commercialhaskell/stackage#6217 (cherry picked from commit 7267499) # Conflicts: # cabal.project # clash-ghc/clash-ghc.cabal # clash-lib/clash-lib.cabal # clash-prelude/clash-prelude.cabal
alex-mckenna
pushed a commit
that referenced
this pull request
Oct 11, 2021
Related: commercialhaskell/stackage#6217 (cherry picked from commit 7267499)
alex-mckenna
pushed a commit
that referenced
this pull request
Oct 11, 2021
Related: commercialhaskell/stackage#6217 (cherry picked from commit 7267499)
alex-mckenna
pushed a commit
that referenced
this pull request
Oct 11, 2021
Related: commercialhaskell/stackage#6217 (cherry picked from commit 7267499)
alex-mckenna
pushed a commit
that referenced
this pull request
Oct 11, 2021
Related: commercialhaskell/stackage#6217 (cherry picked from commit 7267499)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: commercialhaskell/stackage#6217
Write a changelog entry (see changelog/README.md)