Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add parameter public_network_access_enabled parameter #11

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

feat: Add parameter public_network_access_enabled parameter #11

wants to merge 8 commits into from

Conversation

fdmsantos
Copy link
Contributor

Fixes #(issue) .

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Changes proposed in this pull request

  • Add public_network_access_enabled parameter to function app resource (On Windows and Linux)

@claranet/fr-azure-reviewers

BzSpi
BzSpi requested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@BzSpi BzSpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @fdmsantos

Thanks for your contribution 🙏

modules/linux-function/variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
modules/linux-function/variables.tf Outdated Show resolved Hide resolved
modules/windows-function/variables.tf Outdated Show resolved Hide resolved
modules/windows-function/variables.tf Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BzSpi BzSpi BzSpi requested changes

@Shr3ps Shr3ps Awaiting requested review from Shr3ps Shr3ps is a code owner

@rossifumax rossifumax Awaiting requested review from rossifumax rossifumax is a code owner

@jmapro jmapro Awaiting requested review from jmapro jmapro is a code owner

@maxpoullain maxpoullain Awaiting requested review from maxpoullain maxpoullain is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fdmsantos @BzSpi