Add tap and dbltap events #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Trigger CONTAINER_CLICK/DBLCLICK/TAP/DBLTAP with the original event. This can be useful in case the container already contains custom created by other plugins, and it is necessary to determine target of the event. * Rework `tap delay` mechanism and remove DoubleEventHandler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces two new custom events,
CONTAINER_TAPandCONTAINER_DBLTAP, and updatesCONTAINER_CLICKandCONTAINER_DBLCLICKto be triggered alongside their respective original events. The new custom events have potential utility for distinguishing player behavior on mouse versus touch events. For instance, aCONTAINER_TAPevent could be used to display media controls on the first tap and trigger stop/play on the second.Furthermore, this PR includes an additional argument for the trigger touch and click events of the container, which provides the original event. This enhancement could prove valuable for scenarios where HTML elements have already been created by other plugins and nested in a Container, and differentiation is required between the triggered events.
Changes
src/base/events:src/components/container:src/utils/:How to test
Try binding
CONTAINER_TAP/CONTAINER_DBLTAP/CONTAINER_CLICK/CONTAINER_DBLCLICKwithlistenTo