fix(parser): Dont report missing flags as present #5908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we switched flags to `ArgAction::SetTrue`, we overlooked updating `args_present`. Because of the default value for `ArgAction::SetTrue`, `args_present` will always report true when a flag is defined. I went with the trivial implementation for now. We could proactively track this but was unsure about correctness vs overhead and so I thought I'd have those using it pay for it. Looking over uses on github, this will fix a couple bugs but should otherwise be unnoticeable. Fixes clap-rs#5860
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we switched flags to
ArgAction::SetTrue,we overlooked updating
args_present.Because of the default value for
ArgAction::SetTrue,args_presentwill always report true when a flag is defined.I went with the trivial implementation for now. We could proactively
track this but was unsure about correctness vs overhead and so I thought
I'd have those using it pay for it.
Looking over uses on github, this will fix a couple bugs but should
otherwise be unnoticeable.
Fixes #5860