Restore VsCode 1.91 behavior of allowing scripts as executable #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t was possible to execute cmd/bat scripts as executable.
After this update this was suddenly broken.
Our use-case for using such a script has to do with the consistency of our clang-tooling.
We build clang-format, clang-tidy, clangd ... all together and put this in a package manager.
In the script, we first download these executables (when needed) and than start the downloaded clangd.
As such, when fixing an issue in clang-tidy, the same issue will get fixed in the clangd exe.
Without this script, it is impossible to automatically trigger this download and it introduces the risk that we do not update all the tooling to the latest version.
Fixes clangd#683
In this reapply, we quote both the command line and the arguments, such that both can contain spaces.
We also introduce the option useScriptAsExecutable, such that this is only enabled when the user wants it.
|
@HighCommander4 The issue with the space was clear and should be resolved. However, I had the impression that there were other reasons why it failed which we don't know about. |
HighCommander4
requested changes
Nov 19, 2024
src/clangd-context.ts
Outdated
| @@ -68,13 +68,23 @@ export class ClangdContext implements vscode.Disposable { | |||
| if (!clangdPath) | |||
| return null; | |||
|
|
|||
| const useScriptAsExecutable = | |||
| await config.get<boolean>('useScriptAsExecutable'); | |||
There was a problem hiding this comment.
I simplified this a bit in #731 (config.get isn't actually async and doesn't need to be awaited), would you mind rebasing on top of that and querying the config value directly in the constructor?
src/clangd-context.ts
Outdated
| let quote = (str: string) => { return `"${str}"`; }; | ||
| clangdPath = quote(clangdPath) | ||
| for (var i = 0; i < clangdArguments.length; i++) | ||
| clangdArguments[i] = quote(clangdArguments[i]); |
There was a problem hiding this comment.
nit: indent statement inside loop
There was a problem hiding this comment.
Completely agree, will look at it
HighCommander4
added a commit
to HighCommander4/vscode-clangd
that referenced
this pull request
Nov 22, 2024
This reverts commit ea588aa.
HighCommander4
added a commit
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In VsCode 1.72 Node was updated to version 20, before this upgrade, it was possible to execute cmd/bat scripts as executable.After this update this was suddenly broken.
Our use-case for using such a script has to do with the consistency of our clang-tooling.
We build clang-format, clang-tidy, clangd ... all together and put this in a package manager.
In the script, we first download these executables (when needed) and than start the downloaded clangd.
As such, when fixing an issue in clang-tidy, the same issue will get fixed in the clangd exe.
Without this script, it is impossible to automatically trigger this download and it introduces the risk that we do not update all the tooling to the latest version.
Fixes #683
In this reapply, we quote both the command line and the arguments, such that both can contain spaces.
We also introduce the option useScriptAsExecutable, such that this is only enabled when the user wants it.